Project

General

Profile

Feature #2111

noproj - decouple from requiring a target body

Added by Tammy Becker over 4 years ago. Updated 12 days ago.

Status:
Acknowledged
Priority:
High
Assignee:
-
Category:
Applications
Target version:
-
Impact:

The changes should allow noproj to work when there is no intersection with a target body, and allow other instruments supported by ISIS

Software Version:
Test Reviewer:

Description

Remove the need to have a target body in the image. Problems include full sky images, and partial/full disk images where reseaus are not on the target.


Related issues

Related to ISIS - Feature #2090: noproj - needs to work on Voyager and other instruments Acknowledged

History

#1 Updated by Tammy Becker over 4 years ago

According /usgs/cpkgs/isis3/data/base/applications/noprojInstruments003.pvl multiple instruments are supported.

The documentation is completely lacking on what is formally supported an what's not.

#2 Updated by Janet Barrett over 4 years ago

  • Category set to Applications

I ran some tests on noproj. It gives close but not exact results for Viking. The warping is slightly different between Isis2 and Isis3. I also verified that anyone can copy the
noprojInstruments003.pvl file to their directory and add an instrument (such as Voyager). Even though the noproj program then runs successfully on a Voyager image, it does not give
valid results. Since Viking and Voyager both use the ReseauDistortionMap class, I would have assumed that the noproj program would work equally well for both missions. This does not
appear to be the case. I am continuing to investigate the noproj program to find out why it is not working for Voyager.

#3 Updated by Janet Barrett over 4 years ago

I have done more testing with noproj on Voyager data. It appears that noproj works on full frame images taken by Voyager. It was failing on an image containing the disk of Europa
surrounded by sky. I suspect that the reseau points that don't fall on the target are not being used to warp the data. This would explain why full frame Voyager images work successfully
in noproj. I will be adding Voyager support to noproj through the noprojInstruments004.pvl file in $ISIS3DATA/base/applications.

#4 Updated by Janet Barrett over 4 years ago

After looking through the code that applies the transformation for the noproj program, I have discovered that the reseaus are only being used by noproj to create the
undistorted match cube that is then used by cam2cam to do the transformation. The cam2cam transforms the input file to match the geometry of the match cube, but it
only uses data that falls on the target to do the transformation. This is done by taking a line,sample in the output file and obtaining the lat,lon for that point.
The lat,lon is then projected into the input file to get the line,sample to transform to. If the lat,lon doesn't intersect the target in the input file, then the
point isn't used in the transformation. This results in the transformation only being done on those points that intersect the target in the input file. This is a
problem with limb images because the SPICE usually isn't accurate enough to fully intersect the target because it thinks the target is offset from where it actually lies.
ISIS2 uses all of the reseau positions when transforming Viking and Voyager data, regardless of whether they fall on the target or not. ISIS2 noproj does not do any
mapping to ground coordinates when generating an undistorted image. As a result, ISIS2 noproj works on partial frame images.

The noproj program needs to be decoupled from the cam2cam program so that it can do transformations using only the distorted/undistorted focal plane coordinate values and
not using any ground coordinates.

#5 Updated by Tammy Becker about 4 years ago

  • Subject changed from noproj - generalize to support multiple instruments to noproj - generalize to support multiple instruments and decouple from requiring a target body
  • Priority changed from Normal to High

Modified the source from Internal to External based on the recent ISIS-Support HiRISE ticket reported by Sarah Mattson:

https://isis.astrogeology.usgs.gov/IsisSupport/index.php?topic=3870.0

Also modified the subject line to reflect the necessary change to not require a target body in order to correct camera distortion.

#6 Updated by Tammy Becker about 4 years ago

  • Target version set to 3.4.8 (FY15 R1 2014-11-26 Nov)

#7 Updated by Tammy Becker about 4 years ago

Thorough testing should be performed on Viking, Voyager, Messenger and HiRISE (Potential testers: Janet Barrett-comparisons to ISIS2; Annie Howington, Kris Becker, Lynn Weller and Tammy Becker)

#9 Updated by Stuart Sides about 4 years ago

  • Assignee set to Stuart Sides

#12 Updated by Stuart Sides almost 4 years ago

  • Target version changed from 3.4.8 (FY15 R1 2014-11-26 Nov) to 3.4.9 (FY15 R2 2015-03-26 Mar)

#13 Updated by Stuart Sides almost 4 years ago

  • Status changed from Acknowledged to Assigned

#17 Updated by Stuart Sides almost 4 years ago

  • Status changed from Assigned to In Progress
  • Impact updated (diff)

#18 Updated by Stuart Sides over 3 years ago

  • Status changed from In Progress to Acknowledged
  • Assignee deleted (Stuart Sides)

#20 Updated by Kristin Berry over 3 years ago

  • Assignee set to Kristin Berry

#22 Updated by Kristin Berry over 3 years ago

  • Status changed from Acknowledged to In Progress

#23 Updated by Kristin Berry over 3 years ago

  • Target version changed from 3.4.9 (FY15 R2 2015-03-26 Mar) to 3.4.11 (FY16 R1 2015-10-28 Oct)

#24 Updated by Kristin Berry about 3 years ago

test

#25 Updated by Kristin Berry about 3 years ago

test

#27 Updated by Stuart Sides about 3 years ago

  • Assignee changed from Kristin Berry to Stuart Sides

#28 Updated by Stuart Sides almost 3 years ago

  • Subject changed from noproj - generalize to support multiple instruments and decouple from requiring a target body to noproj - decouple from requiring a target body
  • Description updated (diff)

This issue contained two unrelated problems. Subject and Description updated to have only one. The relationship to #2090 was left in place because some notes are for both problems.

#29 Updated by Stuart Sides over 2 years ago

  • Target version changed from 3.4.11 (FY16 R1 2015-10-28 Oct) to 3.4.13 (FY16 R3 2016-08-31 Aug)

#30 Updated by Stuart Sides about 2 years ago

  • Status changed from In Progress to Acknowledged
  • Assignee deleted (Stuart Sides)

#31 Updated by Stuart Sides about 2 years ago

  • Target version deleted (3.4.13 (FY16 R3 2016-08-31 Aug))

Also available in: Atom PDF