Project

General

Profile

Feature #2150

qnet - Add a find point ID option

Added by Ella Lee over 3 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Applications
Target version:
Impact:

Moderate - A new tab was added to Qnet

Software Version:
Test Reviewer:

Description

It would be nice to have an option where you just find a pointid. This will be very helpful in finding the place you were at before you fixed a measure and saved it. The only option we have now is to filter a pointid. I put this under application, not sure if it should go under API.


Related issues

Related to ISIS - Bug #1958: qnet - debug statements going to shell Closed 2014-01-15

History

#1 Updated by Tammy Becker over 3 years ago

  • Subject changed from gnet - find option to cnet - find option
  • Status changed from New to Acknowledged

#2 Updated by Tammy Becker over 3 years ago

  • Subject changed from cnet - find option to qnet - find option

As per discussion with Ella, this is a request for access to a history of edited points/measures. When a user sorts on residuals within qnet, selects a point that contains a high residual measure from the sorted list, edits ("fixes") the measure, saves the point - qnet resorts and reshuffles the list of sorted residuals points...the user then loses reference to the point they just finished editing.

This request is related to ticket #1958 in that the clutter of developer messages on the terminal screen for qnet that was reporting the points edited, Ella ended up using this as a history...now that these messages have been removed under the 1958 ticket, we lost a 'feature' of point history.

#3 Updated by Moses Milazzo almost 3 years ago

It's not clear to me if this is still relevant, but I'm going to include it in FY15Q3 just in case it can be fixed while also fixing #2210 and #2060.

#4 Updated by Stuart Sides almost 3 years ago

  • Target version set to 3.4.10 (FY15 R3 2015-07-23 Jul)

#6 Updated by Stuart Sides over 2 years ago

  • Subject changed from qnet - find option to qnet - Add a find point ID option

#7 Updated by Stuart Sides 4 months ago

  • Target version deleted (3.4.10 (FY15 R3 2015-07-23 Jul))

#8 Updated by Stuart Sides 3 months ago

  • Status changed from Acknowledged to Assigned
  • Assignee set to Adam Goins
  • Target version set to 3.5.2 (2017-01-31 Jan)

#9 Updated by Adam Goins 3 months ago

  • Status changed from Assigned to In Progress

#10 Updated by Adam Goins 3 months ago

  • Status changed from In Progress to Feedback

The ticket requests a "find point ID" option, however in the comments it's clarified that what's being requested is a history of edited points/measures.

I've added a tab to the cnet navigator that contains a running history of edits made to cnet.
Currently it's being updated every time you interact with a point, and records the point that's being interacted with.
The history items are currently just QLabels that contain information on what interaction was made.

I can make the labels behave as an interactable list (highlight on hover) and make it so that the user can right click to bring up a context menu and select a point from the history as well, but this would require subclassing a QLabel and creating a new class for this purpose.
I would like to make the QLabel's interactable so that the user can grab the point ID directly from the QLabel itself.

The history tab is created inside QnetNavTool for a proof of concept, however all of the other tabs in the nav tool are their own class so if this design is deemed appropriate then I will move the tab to it's own class and reference it as such.
The design for this history tab can be changed, or moved entirely (if we want the history displayed elsewhere and not as a tab in the navigator).

As far as the initial issue of finding a point ID, what parameters are we expecting to be able to find the point ID? currently there is a filter option (as mentioned) that filters a point ID, but if we're trying to locate the ID itself then I'm unsure of what parameters we'd use to find it.
Does the history tab serve that purpose by giving the ability to scroll through ID's by history? That's the impression I am under but if not please advise.

If the design is inappropriate or inefficient let me know and I can change it to whatever specs are appropriate.

Changes have been made to /work/projects/isis/latest/m02150/ and built on prog24 for user feedback and testing.

#11 Updated by Adam Goins 3 months ago

Tammy, I'm pinging you on this ticket because you spoke with Ella about it. I added you as a watcher.
Thank you.

#12 Updated by Makayla Shepherd about 2 months ago

  • Target version changed from 3.5.2 (2017-01-31 Jan) to 3.5.3

#13 Updated by Tammy Becker about 1 month ago

I have tested this new feature on astrovm4 using a small control network. The point-id history tab is nice, I like that the most recent selected point-id is always at the top of the list.
I'm not sure where the history can be displayed other than this tabbed area. Documentation needs to be added somewhere to make the users aware of this new feature.
I would not recommend making this an interactive feature; just displaying the history satisfies letting the user know what points have been selected during the qnet session.
I would also not recommend we attempt to "find" any point, the filters under the point tabs are sufficient for now.

I have asked a second user to check this new feature out since qnet is such an important tool.

Thank you.

#14 Updated by Lynn Weller about 1 month ago

I agree with all of Tammy's observations and recommendations. This could be useful and it is certainly better having everything contained in a tab as opposed to going to the users screen as it had been doing when this was posted.

That being said, point id's listed in the new Activity History tab are duplicated whenever the user clicks on Filter or Show All. This is true whether the filtering/resetting is being applied to points or cubes. This should probably be addressed.

#15 Updated by Tammy Becker about 1 month ago

I had noticed the duplication also, could this be addressed during this sprint?

#16 Updated by Adam Goins about 1 month ago

I'm not seeing this behavior when I press filter, but I am seeing it duplicate the points when when "Show all" is pressed. I added a check to ensure duplicate history entries aren't being added back to back. Let me know if this fixes it.

#17 Updated by Tammy Becker about 1 month ago

The duplicated point id's in the Activity History tab has been addressed. The finished hours of this ticket needs to be entered in order for me to close it.

Thank you! Nice job.

#19 Updated by Adam Goins about 1 month ago

  • Status changed from Feedback to Resolved
  • Impact updated (diff)

#20 Updated by Tammy Becker about 1 month ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF