FileName API Documentation Lacking
Documentation will be updated
The FileName class does not have much documentation present. Since this class should be used when handling file names and paths, more documentation would ensure both more usage of the class and proper usage of the class.
#6 Updated by Ian Humphrey over 1 year ago
- Status changed from Code Review to Feedback
Looks good! In your history comment, add "Fixes #4121." to the end of it.
I would put two lines of whitespace between the methods in the header.
FileName::dir() description says "Returns the path of the files parent...", files should be file's
FileName::expanded() description may be easier to read of broken into more than one sentence.
Although not part of the API, quickly document the private methods as well