3rdParty Makefile license target shouldn't hard-code path to third party library areas
In the 3rdParty Makefile, the license target has the following line:
$(RSYNC) -a /usgs/pkgs/local/$(ISISLOCALVERSION)/license/
The /usgs/pkgs/local/ part of the path should not be hard-coded, as the macs have ISIS third parties installed at /opt/usgs/.
Licenses should also be available in the /opt/usgs/ area for copying from, or obtain the licenses from a linux prog's /usgs/pkgs/local/v00X area.
#5 Updated by Ian Humphrey about 1 year ago
- Status changed from Resolved to Feedback
Instead of defining THIRDPARTYLICPATH as /usgs/pkgs/local/$(ISISLOCALVERSION)/license, I think you could define it as $(ISIS3LOCAL)/license ?
I would change the = to := so that the right side is immediately expanded when assigning to THIRDPARTYLICPATH
- http://stackoverflow.com/questions/448910/makefile-variable-assignment kind of explains these different assignment types, I didn't really know what the difference was but this explains it pretty well.
Also, I would only update the files for our currently supported systems:
- MacOSX10_11 (prog17)
- linux-x86_64 (prog21, prog24, astrovm4)
- linux-x86_64_Debian8 (prog23)
- linux-x86_64_Ubuntu14_04 (prog22)