Project

General

Profile

Bug #4134

3rdParty Makefile license target shouldn't hard-code path to third party library areas

Added by Ian Humphrey over 1 year ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Infrastructure
Target version:
Impact:

License

Software Version:
Test Reviewer:

Description

In the 3rdParty Makefile, the license target has the following line:

$(RSYNC) -a /usgs/pkgs/local/$(ISISLOCALVERSION)/license/

The /usgs/pkgs/local/ part of the path should not be hard-coded, as the macs have ISIS third parties installed at /opt/usgs/.

Licenses should also be available in the /opt/usgs/ area for copying from, or obtain the licenses from a linux prog's /usgs/pkgs/local/v00X area.

History

#1 Updated by Stuart Sides 8 months ago

  • Target version set to 3.5.1 (Sprint 1)

#2 Updated by Stuart Sides 8 months ago

  • Status changed from Acknowledged to Assigned
  • Assignee set to Cole Neubauer

#3 Updated by Cole Neubauer 8 months ago

  • Status changed from Assigned to In Progress

#4 Updated by Cole Neubauer 8 months ago

  • Status changed from In Progress to Resolved

Had to set the whole path, not just the first part, because the Mac 3rd party licenses are in $(ISISLOCALVERSION)/3rdParty/license/ instead of $(ISISLOCALVERSION)/license/

#5 Updated by Ian Humphrey 8 months ago

  • Status changed from Resolved to Feedback

Looks good!

Suggestions:

  • Instead of defining THIRDPARTYLICPATH as /usgs/pkgs/local/$(ISISLOCALVERSION)/license, I think you could define it as $(ISIS3LOCAL)/license ?

  • I would change the = to := so that the right side is immediately expanded when assigning to THIRDPARTYLICPATH

  • Also, I would only update the files for our currently supported systems:

    • MacOSX10_11 (prog17)
    • linux-x86_64 (prog21, prog24, astrovm4)
    • linux-x86_64_Debian8 (prog23)
    • linux-x86_64_Ubuntu14_04 (prog22)

#6 Updated by Cole Neubauer 8 months ago

  • Status changed from Feedback to Resolved

#7 Updated by Ian Humphrey 8 months ago

  • Status changed from Resolved to Closed

#8 Updated by Stuart Sides 4 months ago

  • Target version changed from 3.5.1 (Sprint 1) to 3.5.1 (2017-08-08 Aug)

Also available in: Atom PDF