Project

General

Profile

Bug #4505

Bug #2244: Pixel (Line/Sample) Projection Offset Issue

mimap2isis - Import PDS formatted Kaguya MI MAP file to ISIS3 cube format

Added by Tammy Becker about 1 year ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
John Bonn
Category:
Applications
Target version:
Impact:
Software Version:
Test Reviewer:
Story points:
2

Description

Mentor: Trent Hare

As part of the pixel offset issue (import/export)


Related issues

Related to ISIS - Feature #2358: ISIS capability to work with Kaguya MI L3C5 data Closed
Related to ISIS - Documentation #4917: mimap2isis - delete or update Kaguya MI MAP ingest application Acknowledged

History

#1 Updated by Tammy Becker about 1 year ago

  • Related to Bug #2244: Pixel (Line/Sample) Projection Offset Issue added

#2 Updated by Tammy Becker about 1 year ago

  • Related to Feature #2358: ISIS capability to work with Kaguya MI L3C5 data added

#3 Updated by Jason Laura about 1 year ago

  • Status changed from Acknowledged to New

#4 Updated by Jason Laura about 1 year ago

  • Story points set to 2

Similar testing to pds2isis test plan. Run the program and verify the output in the label. Trent will provide the correct values to test with.

#5 Updated by Jason Laura about 1 year ago

  • Status changed from New to Acknowledged

#6 Updated by Trent Hare about 1 year ago

These are going to be preliminary numbers I'm not sure what the correct values should be!

(1) grab map projected Kaguya L35 data (please place in testing location):
/usgs/shareall/TEMP/thare/MI_L3C5_9.9.16/MIA_3C5_03_02024S140E3586SC.img

(2) A bug was just fix and not in stable so first set isis. This fix correctly adjusts the incorrect PDS SAMPLE_PROJECTION_OFFSET
log into prog21 to run beta area
$ isis /work/projects/isis/latest/m02358/isis

(3) run conversion
$ mimap2isis from=MIA_3C5_03_02024S140E3586SC.img to=MIA_3C5_03_02024S140E3586SC_mimap.cub setnullrange=yes nullmin=-30000 nullmax=-30000

(4) test ProjectionOffset X,Y using maplab (in typical ISIS latest area)
maplab from=MIA_3C5_03_02024S140E3586SC_mimap.cub map=MIA_3C5_03_02024S140E3586SC_maplab.cub sample=0.5 line=0.5 coordinates=latlon lat=-13.73339844 lon=358.31103516

Now look at X,Y offsets in both ISIS cubes. They should be the same (but are not).

Just using the pure Simple Cylindrical map projections equation they should be

X = 10865191.07999640 (X = min_lon * PI/180.0 * 1737400) where min_lon = 358.3110352
Y = -416442.65341059 (Y = max_lat * PI/180.0 * 1737400) where max_lat=-13.73339844

ISIS sets them to these values (mimap.cub)
UpperLeftCornerX = -51207.65772 for a difference of 7.41497739
UpperLeftCornerY = -416449.95948 for a difference of 7.50025059

ISIS is apparently also wrapping the the min longitude 358.3110352 (min_Lon - 360) to -1.68896484 (which must be another issue in the label). Perhaps ISIS is running (min_lon - 360) for Longitudes above 180? Anyway, using this the map projection equation would be:

X = -51215.07269739 (X = -1.68896484 PI/180.0 * 1737400)

If ISIS is converting the Lons then it should be reflected in the ISIS output label. Currently they are still being reported as ~358 degrees.

Summary:
X is wonky but seems correct but with a 1/2 pixel offset
Y seems correct but but with a 1/2 pixel offset

So products in PDS standard are suppose to apply a PIXEL_OFFSET by adding 0.5 pixels to get to the corner from the pixel center. For this label the offset should be 0.0.

#7 Updated by Robert Sucharski about 1 year ago

  • Assignee set to Robert Sucharski

#8 Updated by Robert Sucharski about 1 year ago

  • Status changed from Acknowledged to Assigned

#9 Updated by Jason Laura about 1 year ago

  • Target version changed from 225 to 227

#10 Updated by Jason Laura about 1 year ago

  • Status changed from Assigned to Acknowledged

#11 Updated by Robert Sucharski about 1 year ago

  • Status changed from Acknowledged to In Progress

#12 Updated by Robert Sucharski about 1 year ago

  • Status changed from In Progress to Resolved

#13 Updated by Marjorie Hahn about 1 year ago

  • Status changed from Resolved to Code Review

#14 Updated by Marjorie Hahn about 1 year ago

  • Status changed from Code Review to Feedback

Looks good to me, I would just delete the "StepNumber=" field altogether and also note whether the test is currently passing or failing under "Pass/Fail".

#15 Updated by Stuart Sides 10 months ago

  • Target version deleted (227)

#16 Updated by Stuart Sides 7 months ago

  • Tracker changed from UserTestPlan to Bug
  • Target version set to 3.5.1 (Sprint 1)

User test plan done, changed to bug.

#17 Updated by John Bonn 7 months ago

The PDS updates resulted in the following change to the ISIS cube (tested by the mimap2isis default test):

 UpperLeftCornerX   = -970339.58436 <meters>
 UpperLeftCornerY   = 1971009.91524 <meters>
to
 UpperLeftCornerX   = -970354.39068 <meters>
 UpperLeftCornerY   = 1971024.72156 <meters>

this is consistent with the 1 pixel offset at a scale of

    MAP_SCALE                        = 1.480632e-02 <km/pixel>^M

#18 Updated by John Bonn 7 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Robert Sucharski to John Bonn
  • Parent task set to #2244

#19 Updated by Trent Hare 6 months ago

  • Related to Documentation #4917: mimap2isis - delete or update Kaguya MI MAP ingest application added

#20 Updated by Stuart Sides 5 months ago

  • Status changed from Resolved to Closed

Closed after testing by Trent

#21 Updated by Stuart Sides 4 months ago

  • Target version changed from 3.5.1 (Sprint 1) to 3.5.1 (2017-08-08 Aug)

Also available in: Atom PDF