Project

General

Profile

Recommendation #4535

pixel2map should have an "errors" app test

Added by Ian Humphrey about 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Curtis Rose
Category:
Applications
Impact:

Correctly checks the number of bands of multiple input files now.

Software Version:

Description

Currently pixel2map does not test the exceptions that it can throw.

To improve test coverage of this application, an "errors" test should be written that can exercise any testable exceptional cases. pixel2map can throw the following exceptions in the following cases:

// The FROMLIST file is empty
if (list.size() < 1)

USER The list file [FROMLIST] does not contain any data.

// Make sure the target is not the sky
if (g_incam->target()->isSky())

USER The image [cube] is targeting the sky, use skymap instead.

// Make sure all the bands for all the files match
if (i > 1 && atts0.bandsString() != lastBandString)

USER The Band numbers for all the files do not match.

// Image crosses longitude seam and LONSEAM is set to ERROR
else if (ui.GetString("LONSEAM") == "ERROR")

USER The image [cube] crosses the longitude seam

See the following internal wiki page for more information about testing exceptions in an app test.

History

#1 Updated by Ian Humphrey about 1 year ago

  • Description updated (diff)

#2 Updated by Tammy Becker about 1 year ago

  • Status changed from New to Acknowledged

#3 Updated by Curtis Rose about 1 year ago

  • Assignee set to Curtis Rose

#4 Updated by Curtis Rose about 1 year ago

  • Status changed from Acknowledged to In Progress

#5 Updated by Curtis Rose about 1 year ago

  • Impact updated (diff)

#6 Updated by Curtis Rose about 1 year ago

  • Status changed from In Progress to Resolved

#7 Updated by Ian Humphrey about 1 year ago

  • Status changed from Resolved to Closed

reviewed changes, looks good!

#8 Updated by Stuart Sides 10 months ago

  • Target version changed from 214 to 3.5.0 (FY17 2017-01-25 Jan)

Also available in: Atom PDF