Bug #2244: Pixel (Line/Sample) Projection Offset Issue
documentation for pds2isis
We need a good place either on the pds2isis page or ISIS help docs which lists this change and the use and importance of the configuration file:
The current mapping in this file might be a table on that page (or at least this file accessible to others).
This should also discuss that ISIS defines the top left corner as 0.5 line 0.5 sample as stated here:
This implies the center of the top-left pixel is 1,1
The abstract should be pointed to as a reference (which can help explain our current understanding for the offset values in PDS):
#4 Updated by John Bonn over 1 year ago
Added the following text to the /usgs/cpkgs/isis3/data/base/translations/README.txt file:
pdsProjectionLineSampToXY_V2.def replaces pdsProjectionLineSampToXY.def for Isis version 3.5.1 and above. This has the corrected PDS offset data to fix bug m02244 "Pixel (Line/Sample) Projection Offset Issue".
The following header has been been added to pdsProjectionLineSampToXY.def
# # # ******** THIS FILE HAS BEEN DEPRECATED AS OF VERSION 3.5.1 OF ISIS ******** # # it has been replaced by pdsProjectionLineSampToXY_V2.def # #
Note we still need real documentation on this.
#6 Updated by Trent Hare over 1 year ago
The current version of this file now only contains PDS3 archives that require label overrides to correct for known issues. It will be updated if needed. It is here just for reference. Note that ISIS2 files are listed here since they imported into ISIS3 using the same pds2isis routine and do not use the same PDS3 mults or offsets.
# This file is used by the ProcessImportPds class to define the offset and # multiplication factors to convert between sample/line and x/y. # # The Keyword defines which keyword is searched for in the pds file. The # Pattern is then used to match the value in the defined keyword. If there # is a match, the given values are used. # The defaults used in ProcessImportPds are: # xMult = -1.0 # yMult = 1.0 # xOff = 0.5 # yOff = 0.5 # # Equations used are # # upperLeftX = xmult * (sampleOffset + xOff) * PixelResolution # upperLeftY = ymult * (lineOffset + yOff) * PixelResolution # # Anytime a new group is added to this file, all 6 keywords need to be # defined (Keyword,Pattern,xMult,yMult,xOff,yOff). # # @history 2007-04-10 Tracie Sucharski, Original version with # Isis2 definitions. # @history 2008-06-10 Jeff Anderson, Fixed Magellan to be more specific to # FMAPS and MIDRS # @history 2008-10-01 Steven Lambright, Fixed Isis 2 offsets, fixed cassini radars # Keyword/Pattern values. Commented and fixed MIDR offsets. # @history 2011-01-26 Janet Barrett, Added support for Kaguya Terrain Camera # (TC_MAP) # @history 2011-11-16 Jeff Anderson, Added support for LROC data # @history 2012-03-04 Janet Barrett, Added support for Kaguya Terrain Camera # Ortho data (TCO_MAP) # @history 2017-05-25 J Bonn KAGUYA TERRAIN CAMERA and KAGUYA TERRAIN CAMERA # ORTHO entires to +0.5 yoff,yoff per ticket m04506 # @history 2017-05-26 T Hare With ticket m02244 fix, removed entires that no # longer need an override including: CHANDRAYAAN and LRO # MINIRF, CASSINI RADAR, LROC PDS RDR, MESSENGER DEM, and # HRSC PDS products. Added new entry for MGS MOLA Object = ProjectionOffsetMults # MAGELLAN - MIDR # Must stay above ISIS2 # Magellan MIDR file labels were converted from VICAR labels to PDS # labels, and in this conversion the sample/line offsets were rounded # to whole numbers; subpixel accuracy was lost. Because of this, we'll # never exactly match the latitude/longitude but we can be close. Group = Selection Keyword = "DATA_SET_ID" Pattern = "MGN-V-RDRS-5-MIDR" xMult = -1.0 yMult = 1.0 xOff = -0.5 yOff = 1.0 End_Group # VIKING ORBITER Group = Selection Keyword = "DATA_SET_ID" Pattern = "VO1/VO2-M-VIS-5-DIM-V1.0" xMult = -1.0 yMult = 1.0 xOff = -1.0 yOff = -1.0 End_Group # ISIS2 Group = Selection Keyword = "CCSD3ZF0000100000001NJPL3IF0PDS200000001" Pattern = "SFDU_LABEL" xMult = 1.0 yMult = -1.0 xOff = -0.5 yOff = -0.5 End_Group # MAGELLAN - FMAP Group = Selection Keyword = "DATA_SET_ID" Pattern = "MGN-V-RDRS-5-DIM" xMult = 1.0 yMult = -1.0 xOff = 1.5 yOff = 1.5 End_Group # KAGUYA TERRAIN CAMERA ORTHO Group = Selection Keyword = "DATA_SET_ID" Pattern = "TCO_MAP" xMult = 1.0 yMult = 1.0 xOff = 0.5 yOff = 0.5 End_Group # KAGUYA TERRAIN CAMERA Group = Selection Keyword = "DATA_SET_ID" Pattern = "TC_MAP" xMult = 1.0 yMult = 1.0 xOff = 0.5 yOff = 0.5 End_Group # MOLA MEGDR Group = Selection Keyword = "DATA_SET_ID" Pattern = "MGS-M-MOLA-5-MEGDR-L3-V1.0" xMult = -1.0 yMult = 1.0 xOff = -0.5 yOff = -0.5 End_Group End_Object
#7 Updated by Trent Hare over 1 year ago
- Status changed from Assigned to Closed
Still can't attach anything here but here is a link to the current version to document the PDS/ISIS3 Pixel Offset resolution. I assume this will go in the release note for 3.5.1 and maybe an ISIS WIKI page or... Comments or corrections are still welcome.