Project

General

Profile

Bug #4581

isisminer needs some clarification/corrections to documentation and a few code changes/corrections

Added by Kris Becker 11 months ago. Updated 6 months ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Applications
Impact:

isisminer's GisOverlap strategy will no longer output the "Total Geoms" text when debug is false.

Software Version:
Test Reviewer:

Description

The isisminer application has the following issues that need to be corrected/addressed:

1) GisOverlapStrategy is writing "Total Geoms:" text to the screen unconditionally. This needs to be turned into a debugging statement or removed.

2) The CalculatorStrategy does not recognize variables/keywords with underscores in them when it should. Underscores are common in keywords in PDS PVL products and archives index tables. This problem is either in the Calculator or InlineCalculator classes.

3) In the GisOverlapStrategy, the description of OverlapMerge=Intersect is incorrect. "Intersect" needs to be "Intersection" in the XML docs. It is currently throwing an error.

4) Need to document the Header keyword in the CsvReader strategy. It currently does not exist in the XML docs but is used/useful in cases where the CSV input file does not have a header. The Header keyword is the only way to specify column names in this case (when HasHeader = False).

5) The example for CsvWriter in the XML docs is incorrect. The Filename keyword needs to be CsvFile.

6) Evaluate if each Resource needs to be added to Global parameter space when using the Sidebar strategy. Currently, only AssetSidebar does this.

7) Look into unconditional use of the GEOS RTree in StereoPair strategy. It may be more efficient to employ the Direct computation of intersections rather than this approach.

History

#1 Updated by Kris Becker 11 months ago

isisminer needs a better way to report and log details about the execution of each strategy, particularly when in the Sidebar and AssetSidebar strategies. Currently only the main reports this information and embedded strategies that run in these scopes don't show this data.

#2 Updated by Jesse Mapel 11 months ago

  • Assignee set to Jesse Mapel

#3 Updated by Jesse Mapel 11 months ago

  • Status changed from New to Resolved
  • Impact updated (diff)

6) and 7) were not completed due to time constraints for this ticket.

#4 Updated by Jesse Mapel 11 months ago

It was discovered that isisminer does not support logical and, or operators so they are being added.

#5 Updated by Kris Becker 6 months ago

  • Status changed from Resolved to Closed

Thanks!

Also available in: Atom PDF