Project

General

Profile

Bug #4611

ProcessRubbersheet startprocess limitation

Added by Stuart Sides 10 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
API
Target version:
Impact:

ProcessRubberSheet's StartProcess counts loops with long longs instead of ints

Software Version:
Test Reviewer:

Description

THe ProcessRubbersheet class has a limitation on the number of tiles that can be processed. The for loop variable in StartProcess line 182 is being held in a int. If the tile size is set very low, the number of tiles becomes a large number, and could overflow the int. This loop variable should be a long long int or ISIS::bigint. This may cause cam2map, map2map, rotate, ... to fail unexpectedly.

Also, the otile.begin() for loop at line 204 should be checked for a similar problem.

History

#1 Updated by Stuart Sides 7 months ago

  • Target version set to 3.5.1 (Sprint 1)

#2 Updated by Christopher Combs 6 months ago

  • Assignee set to Christopher Combs

#3 Updated by Christopher Combs 6 months ago

  • Status changed from Acknowledged to In Progress

#4 Updated by Christopher Combs 6 months ago

  • Status changed from In Progress to Resolved
  • Impact updated (diff)

#6 Updated by Stuart Sides 6 months ago

Spend a little time to bring the class up to standards

#7 Updated by Stuart Sides 6 months ago

  • Status changed from Resolved to Closed

#8 Updated by Stuart Sides 4 months ago

  • Target version changed from 3.5.1 (Sprint 1) to 3.5.1 (2017-08-08 Aug)

Also available in: Atom PDF