Project

General

Profile

Bug #4731

Application name does not appear at the top of GUI window banner

Added by Tammy Becker 8 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Applications
Target version:
Impact:

Titles will now be displayed

Software Version:
Test Reviewer:

Description

This is a new observed issue under isis3.5.0 astrovm4.

All GUI application windows no longer display the program name.

Under the putty/Xming environment the GUI banner window displays "Xming X" in place of the application name.

History

#1 Updated by Tammy Becker 8 months ago

  • Target version set to 3.5.1 (Sprint 1)

#2 Updated by Stuart Sides 8 months ago

  • Status changed from Acknowledged to Assigned
  • Assignee set to Cole Neubauer

#3 Updated by Cole Neubauer 7 months ago

  • Status changed from Assigned to In Progress

#4 Updated by Cole Neubauer 7 months ago

  • Impact updated (diff)

#5 Updated by Cole Neubauer 7 months ago

  • Status changed from In Progress to Resolved

#7 Updated by Ian Humphrey 7 months ago

  • Test Reviewer set to Tammy Becker

#8 Updated by Ian Humphrey 7 months ago

  • Status changed from Resolved to Code Review

#9 Updated by Cole Neubauer 7 months ago

Commands To Test:
setisis /work/projects/isis/latest/m04731/trunk/isis/
algebra &

The title of the window should now be the name of the application, in this case algebra should be the title.

#10 Updated by Ian Humphrey 7 months ago

Review Notes:

  • I would remove the //argv[0] = "Test" comment before you commit.
  • At line 94, the style variable shouldn't need to be cast to a QString.
  • At line 275, there is a call:
QApplication::setApplicationDisplayName(FileName("argv[0]").baseName());

I don' think that call should be creating a FileName from the string "argv[0]".

  • Isis.h should probably not be modified.

Also, when testing this by ssh'ing directly to astrovm4 (i.e. not using putty), the title bar says:

algebra - argv[0]

#11 Updated by Ian Humphrey 7 months ago

  • Status changed from Code Review to Feedback

#12 Updated by Cole Neubauer 7 months ago

  • Status changed from Feedback to Resolved

#13 Updated by Ian Humphrey 7 months ago

Looks good, ran through putty and directly through ssh, title is "algebra" in both cases.

#14 Updated by Tammy Becker 7 months ago

  • Status changed from Resolved to Closed

It worked for me as well, through putty, xming on astromv4.

Thank you!

#15 Updated by Stuart Sides 4 months ago

  • Target version changed from 3.5.1 (Sprint 1) to 3.5.1 (2017-08-08 Aug)

Also available in: Atom PDF