Project

General

Profile

Bug #4870

cnetcombinept should set merged control measure types to Candidate so that pointreg can be run efficiently

Added by Kris Becker 7 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Applications
Target version:
Impact:
Software Version:
Test Reviewer:

Description

cnetcombinept should set merged control measure types to Candidate so that pointreg can be applied to only those merged measures when registering to the (typically) new reference measure.

It would be best if the actual image measure coordinates could be updated to match the new reference in the master point, but not enough information is available (need, at a minimum, the pixel resolution of both images at that measure). If the reference measures are the same, then the measure type should NOT be modified.

NOTE: It is highly recommended that pointreg be run after cnetcombinept with this new change as merged measures are very likely only registered to within IMAGETOL pixels at best (remember: IMAGETOL is compared to the average offset of all common measures in merge point pairs so some measures could be greater than IMAGETOL pixels from the reference measure).


Related issues

Related to ISIS - Bug #4772: cnetcombinept doesn't properly set a prior lat/lon to the adjusted values Closed
Related to ISIS - Bug #4869: cnetcombinept doesn't properly combine control points that contain the same control measures in each point (i.e., duplicates) Closed

History

#1 Updated by Kris Becker 7 months ago

  • Related to Bug #4772: cnetcombinept doesn't properly set a prior lat/lon to the adjusted values added

#2 Updated by Kris Becker 7 months ago

  • Related to Bug #4869: cnetcombinept doesn't properly combine control points that contain the same control measures in each point (i.e., duplicates) added

#3 Updated by Tammy Becker 7 months ago

  • Status changed from New to Acknowledged

#4 Updated by Tammy Becker 7 months ago

  • Target version changed from 3.5.1 (Sprint 1) to 3.5.1 (2017-08-08 Aug)

#5 Updated by Stuart Sides 6 months ago

  • Target version changed from 3.5.1 (2017-08-08 Aug) to 3.5.1 (Sprint 1)

#6 Updated by Tyler Wilson 6 months ago

  • Assignee set to Tyler Wilson

#7 Updated by Tyler Wilson 6 months ago

  • Status changed from Acknowledged to In Progress

#8 Updated by Tyler Wilson 6 months ago

  • Status changed from In Progress to Resolved

#9 Updated by Tyler Wilson 6 months ago

To make things easier for testing, I have combined all three of the cnetcombinept tickets into one ticket which can be tested by pointing your ISIS version here:

/work/projects/isis/latest/m04870_4772_4869/isis/

The other two tickets are:
https://isis.astrogeology.usgs.gov/fixit/issues/4772
https://isis.astrogeology.usgs.gov/fixit/issues/4869

#10 Updated by Lynn Weller 6 months ago

Yep, this appears to be working now. Points combined from one point into another has MeasureType=Candidate, as best I can tell (meaning it's hard to track what is/isn't being combined.
Others need to chime in before this can be closed.

#11 Updated by Kris Becker 6 months ago

Umm, this comment applies to this ticket as well but is duplicated in #4869 as well.

One additional change that needs to be made is to determine if the reference measures on both points are the same. In this case, you will not set the point to Candidate but leave the type unchanged.

This should be test for prior to the loop that merges individual measures and a flag set to make the update if reference measures are different.

This is an unlikely case, but will save time if it does occur.

#12 Updated by Kris Becker 6 months ago

Also, please make an entry for each mod in the XML file!

#13 Updated by Kris Becker 6 months ago

  • Status changed from Resolved to Closed

Thanks

#14 Updated by Stuart Sides 4 months ago

  • Target version changed from 3.5.1 (Sprint 1) to 3.5.1 (2017-08-08 Aug)

Also available in: Atom PDF