Project

General

Profile

Bug #4895

FileTool.cpp methods

Added by Kaj Williams 6 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Low
Category:
Applications
Target version:
Impact:

FileTool now stacks errors.

Software Version:
Test Reviewer:

Description

In FileTool.cpp there are two methods where a cube is saved:
void FileTool::saveAsEnlargedCube(Cube *icube, const QString & psOutFile)
void FileTool::saveAsReducedCube(Cube *icube, const QString & psOutFile)

The try...catch blocks in both of these methods assume only one exception could ever occur, and that the unspecified catch is for a file permissions issue (e.g. file I/O exception).
The error message they currently display is "Error", "Cannot open file, please check permissions".

Setting aside the possibility that the exception could stem from other causes not related to file permissions, this message should instead read something like
"Error","The file could not be saved." (possibly mention permissions, though there could obviously be other reasons).


Related issues

Related to ISIS - Bug #4147: qview Save As radio buttons not well defined and sometimes do not save the mapping group to the new cube Closed

History

#1 Updated by Tammy Becker 6 months ago

  • Status changed from New to Acknowledged
  • Target version set to 3.5.1 (2017-08-08 Aug)

#2 Updated by Tammy Becker 6 months ago

  • Related to Bug #4147: qview Save As radio buttons not well defined and sometimes do not save the mapping group to the new cube added

#4 Updated by Stuart Sides 6 months ago

  • Target version changed from 3.5.1 (2017-08-08 Aug) to 3.5.1 (Sprint 1)

#5 Updated by Ian Humphrey 6 months ago

  • Assignee set to Christopher Combs

#6 Updated by Christopher Combs 6 months ago

  • Status changed from Acknowledged to Assigned

#7 Updated by Christopher Combs 6 months ago

  • Status changed from Assigned to In Progress

#8 Updated by Christopher Combs 6 months ago

  • Status changed from In Progress to Resolved
  • Impact updated (diff)

Built on prog17 in /work/projects/isis/latest/m04895.

To test:
- Open a cube in qview and zoom in past 100%.
- Try to save in a directory that doesn't exist with option "Export Viewport As Is" selected.

#9 Updated by Kaj Williams 6 months ago

Was this really built on prog17? The binary file is not executable on prog17...

#10 Updated by Christopher Combs 6 months ago

Built for Fedora

#12 Updated by Kaj Williams 6 months ago

  • Status changed from Resolved to Closed

#13 Updated by Stuart Sides 4 months ago

  • Target version changed from 3.5.1 (Sprint 1) to 3.5.1 (2017-08-08 Aug)

Also available in: Atom PDF