Project

General

Profile

Bug #4900

PvlTranslationTable validation

Added by Cole Neubauer about 1 year ago. Updated 6 months ago.

Status:
In Progress
Priority:
Normal
Category:
API
Target version:
Impact:

Translation files now being checked for validity when adding pvl tables via these files

Software Version:
Test Reviewer:

Description

PvlTranslationTable currently does not check a translation file for valid keywords as it does when it is given a stream
See PvlTranslationTable::AddTable(FileName transFile) and
PvlTranslationTable::AddTable(std::istream &istr)

The AddTable function should do the same checking when given a translation File as when it is given a stream.

History

#2 Updated by Tammy Becker about 1 year ago

  • Status changed from New to Acknowledged

#3 Updated by Stuart Sides 9 months ago

  • Target version deleted (3.5.1 (2017-08-08 Aug))

#4 Updated by Stuart Sides 7 months ago

  • Assignee set to Summer Stapleton
  • Target version set to 3.5.2 (2017-01-31 Jan)

#5 Updated by Summer Stapleton 7 months ago

  • Status changed from Acknowledged to In Progress

#6 Updated by Summer Stapleton 7 months ago

  • Status changed from In Progress to Resolved
  • Impact updated (diff)

Changes made in /work/projects/isis/latest/m04900

I ended up separating the logic to validate a cube from the AddTable(std::istream &transStm) and made a validateTable() method that both AddTable() methods now call. The tgocassis2isis was the only app that I could find that made use of the AddTable(const QString &transFile), so I ran those app tests as well as the PvlTranslationTable test which made a call to the AddTable(std::istream &transStm), so should be working for both methods.

#7 Updated by Cole Neubauer 6 months ago

  • Status changed from Resolved to Feedback

Lines 50-51 need to be changed back, looks like a typo.

Besides that the logic of everything looks sound and it is now doing the proper checking.

#8 Updated by Summer Stapleton 6 months ago

  • Status changed from Feedback to Resolved

Fixed that typo issue.

#9 Updated by Summer Stapleton 6 months ago

  • Status changed from Resolved to Closed

#10 Updated by Summer Stapleton 6 months ago

  • Status changed from Closed to In Progress

Reopened to address issues with nightly testing.

Also available in: Atom PDF