Project

General

Profile

Feature #5097

Create cubelists from open cubes in qview

Added by Kristin Berry 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Applications
Target version:
Impact:

Minimal -- The added functionality should have minimal impact

Software Version:
Test Reviewer:

Description

Sometimes, when looking for good data to use for testing, I open a bunch of cubes in qview and then close the ones that don't contain usable testing data. It would be great to be able to export a list of the filenames of open cubes from qview so that I don't have to manually copy the names of the remaining "good" open cubes down each time.


Related issues

Related to ISIS - Documentation #5140: Document new qview feature: creating cubelists from open cube. Acknowledged

History

#1 Updated by Kristin Berry 10 months ago

  • Subject changed from Create and export cubelists from open cubes in qview to Create cubelists from open cubes in qview

#2 Updated by Kristin Berry 10 months ago

  • Description updated (diff)

#3 Updated by Tammy Becker 10 months ago

  • Status changed from New to Acknowledged

#4 Updated by Stuart Sides 9 months ago

  • Status changed from Acknowledged to Assigned
  • Assignee set to Adam Goins
  • Target version set to 3.5.2 (2017-01-31 Jan)

#6 Updated by Adam Goins 9 months ago

  • Status changed from Assigned to In Progress
  • Impact updated (diff)

#7 Updated by Adam Goins 9 months ago

  • Status changed from In Progress to Resolved

Active cubes can now be exported into a cubelist (.lis) file by using the "Export to List" menu item located in the file menu of qview.

With cubes open, do

File -> Export to List

From there you can select where to save your cubelist file to.

#8 Updated by Robert Sucharski 9 months ago

Tested, and the application worked as expected. Nice feature.

#9 Updated by Kristin Berry 9 months ago

I also tested this and it looks great! Thanks for adding this feature!

#10 Updated by Cole Neubauer 9 months ago

FileTool.cpp

Add double spacing in between all functions. After a functions closing bracket there should be two lines in between it and the next functions start.

There might be too much commenting going on. Keep in mind that the code itself should be able to tell most of whats happening to a programmer reading through it. When you over comment it can just clutter the screen more and possibly reduce readability. For example an unnecessary the block
// This will be a list containing the file paths for all open cubes
QList cubePaths;
doesn't need to be commented. This comment should be removed and the variable renamed to cubeFilePaths and then a programmer can easily see this is a QList of QStrings containing the file paths of the cubes.
Look for other spots in your code where you can remove your comments and possibly make use of better variable names to avoid the need for a comment. When you are writing comments think why not what.

FileTool.h
Needs a history comment

#11 Updated by Cole Neubauer 9 months ago

  • Status changed from Resolved to Feedback

#13 Updated by Tammy Becker 9 months ago

I actually like this feature. The ability to export the list on what is displayed is nice.
As with the ticket #5098 (ctrl-c), I tested the same scenarios below:

1) a collection of images from a different directory, closed two out of 7. exported the list which resulted in the 5 remaining displayed images. I really like that the input directory path is included!
I questioned this in #5098 because only the base filename is kept, so an inconsistent behavior with this ticket. Other users might need to weigh in on this fir #5098. Most certainly I like the path in this export-list feature.

2) tried it with the browse feature, displayed a few images in this window, the last one remaining is what is exported - this is good (with the directory path included); also good

3) tried it with an isis2 which invokes the pds2isis (creates a temporary file in the current directory)..the original filename and path is exported to the list - this is very good.

Where will this new feature be documented?

#14 Updated by Kristin Berry 9 months ago

  • Status changed from Feedback to Closed

#15 Updated by Kristin Berry 9 months ago

  • Related to Documentation #5140: Document new qview feature: creating cubelists from open cube. added

Also available in: Atom PDF