Project

General

Profile

Bug #5235

Bugfixes and readability improvements for socetframesettings

Added by Trent Hare 28 days ago. Updated 25 days ago.

Status:
Acknowledged
Priority:
Normal
Assignee:
-
Category:
Applications
Target version:
-
Impact:
Software Version:
Test Reviewer:

Description

Update to socetframesettings from O-Rex Team member.
https://github.com/drbitboy/isis_socetframesettings

New items
A new branch (20171116/cleanup) that renames variables to correctly describe what the variable is for
* This is now in pull request 2 (PR2) i.e. https://github.com/drbitboy/isis_socetframesettings/pull/2
* It proposes a merge into the earlier branch (20171116/add-orx)
* This branch has many changes that, IMNSHO, make the program easier to understand
* Note that we should review pull request (PR1) first, as the changes are far less extensive and more easily understood
* The tests below confirm that PR2 does functionally the same thing as PR1

Some test data and scripts to test the changes.
* There is a ZIP file of compressed Clementine UVVIS, Messenger NAC and WAC, and ORX Map and Poly CUBs
* They have been modified for use with socetframesetting only, to product test .set files

  • socetframesettings only uses the labels and table
  • The image data have been set to nulls so they compress well
  • I wrote a script to build the socetframesettings ISIS app on my laptop; YMMV.
  • I wrote a script to run tests and generate .set files.
  • There is a master script that generates .set files from each of the branches and compares them.
  • The three branches are
  • 20171116/original - the current code from isisdist.astrogeology.usgs.gov
  • This code produces ORX .set files usable with .raw files containing images flipped on a diagonal from the ISIS CUBs
  • 20171116/add-orx - the minimal changes to fix the original code, but still requires a vertical flip from the ISIS CUBs
  • 20171116/cleanup - fixes several incorrect variable names

The results are
* The add-orx branch fixes the ORX kappa values (adds 270deg).
* The add-orx branch does not change results from the other missions's CUBs.
* The cleanup branch does not break anything in add-orx.

Note: For O-Rex when using the new socetframesettings ISIS app to generate .set files, don't forget to use ISIS flip (not mirror) before writing the corresponding raw files for SOCET SET

History

#1 Updated by Moses Milazzo 25 days ago

  • Tracker changed from Feature to Bug
  • Subject changed from upgrade for socetframesettings to Bugfixes and readability improvements for socetframesettings
  • Status changed from New to Acknowledged

Also available in: Atom PDF