Project

General

Profile

Feature #5260

Update how we read in ControlPoints to avoid protobuf errors with large ControlNetworks.

Added by Kristin Berry 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
None
Assignee:
Category:
API
Target version:
-
Impact:

No impact expected with smaller control networks. It may now be possible to read in larger control networks than before without error. Minor improvement in memory usage when reading large networks.

Software Version:
Test Reviewer:

Description

When reading in a Control Newtork, read streams need to be recreated more often to avoid protobuf errors.

History

#1 Updated by Jesse Mapel 10 months ago

  • Category set to API
  • Status changed from In Progress to Resolved
  • Impact updated (diff)

What was happening is that we were reusing one of protobuf's input streams that maintains an internal buffer. With very large control points (read lots of measures) this was bumping into the buffer size limit imposed by protobuf for security reasons. Changing how we reuse these streams fixes the problem.

github pull request

#2 Updated by Kristin Berry 10 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF