Project

General

Profile

Recommendation #5303

Logic in apollopaninit can be handled in translation file

Added by Summer Stapleton 5 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Applications
Impact:

apollopaninit uses its translation file more efficiently.

Software Version:

Description

Much of the logic implemented in the apollopaninit app can/should be handled by the translation file when written correctly. It appears that the translation file, as it currently exists, is not doing much.

History

#2 Updated by Makayla Shepherd 3 months ago

  • Status changed from New to Acknowledged

#3 Updated by Makayla Shepherd about 2 months ago

  • Status changed from Acknowledged to Assigned
  • Assignee set to Makayla Shepherd

#4 Updated by Kaitlyn Lee about 2 months ago

  • Assignee changed from Makayla Shepherd to Kaitlyn Lee

#5 Updated by Kaitlyn Lee about 2 months ago

  • Status changed from Assigned to In Progress

#6 Updated by Kaitlyn Lee about 1 month ago

  • Status changed from In Progress to Resolved
  • Impact updated (diff)

#7 Updated by Kaitlyn Lee about 1 month ago

Hi Jeannie,
I added you as a watcher so that I can communicate with you and Summer at the same time.

I built ISIS in /work/projects/isis/latest/m05303/

A few things to note:

  • I made it so that all keywords are added with Auto, then the values are updated after. This way order is preserved. This does require me to set a few of the keywords to placeholder values. Then with a PvlTranslationTable (this is needed because the values will end up being an array), I translate the values that need to be updated. An example is TargetAttitudeShape.

  • I split the original translation file into two, and they are in /work/users/kdlee/m05303/ for now. I am now thinking that we do not necessarily have to split the file into two since everything is being added with Auto, but it may be more intuitive to have the Instrument and Kernels keywords added separately.

Thank you!

Also available in: Atom PDF